[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14846 [Tor]: Controller: retrieve an HS descriptor of a service run by a user

#14846: Controller: retrieve an HS descriptor of a service run by a user
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  donncha
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  trivial  |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  SponsorR, tor-hs, controller,
   Resolution:           |  027-triaged-1-in, SponsorS, TorCoreTeam201508
Actual Points:           |  Parent ID:  #3521
       Points:  small    |
-------------------------+-------------------------------------------------
Changes (by donncha):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the initial review:

 * Apologies those commits where a bit all over the place. I've no made
 `git rebase` my friend and will try to push tidier sets of commits in
 future :). I've split the identation and code changes from `a454cd93b`
 into separate commits.

 * I've added an argument to rend_cache_lookup_entry() so that it can also
 be used to query the service-side descriptor cache.

 * The code:
 {{{
 for (i = 0; i < smartlist_len(descs); i++)
         rend_encoded_v2_service_descriptor_free(smartlist_get(descs, i));
 }}}
   was already in `upload_service_descriptor()`. I didn't want to change
 that while adding more code, should I add a commit to change that to the
 `SMARTLIST_FOREACH` style?

 * Yes, that stored log message is still output after `997d596`.

 * I've add a short description of `rend_service_cache` where is is defined
 in the `rendcache.c`.

 I've pushed a new rebased branch which contains the suggestions you made
 at https://github.com/DonnchaC/tor/pull/2/commits. FYI GitHub has a ?w=1
 option which hides whitespace changes in the displayed diff:
 https://github.com/DonnchaC/tor/pull/2/files?w=1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14846#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs