[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19651 [Metrics/CollecTor]: add missing scripts to collector.git

#19651: add missing scripts to collector.git
-------------------------------+--------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  task               |         Status:  needs_revision
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Commits until b0a7e58 look good except for one change: Can we set
 `WORKDIR="tarballs"`?  It's certainly good to make paths configurable, but
 picking different defaults than what's currently hard-coded is a bit
 unexpected.  Think of the current operator who might pull in this change
 in a couple of weeks or months and doesn't remember that paths have
 changed.  Happy to make this change, if you agree, and then push changes
 to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19651#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs