[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21979 [Core Tor/Tor]: prop224: Load and configure service

#21979: prop224: Load and configure service
----------------------------------------------+----------------------------
 Reporter:  dgoulet                           |          Owner:  dgoulet
     Type:  enhancement                       |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.2.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tor-hs, prop224, review-group-19  |  Actual Points:
Parent ID:  #20657                            |         Points:  6
 Reviewer:  asn                               |        Sponsor:  SponsorR-
                                              |  must
----------------------------------------------+----------------------------

Comment (by asn):

 Hey David, I submitted the first round of review on gitlab. I'm still not
 done with the branch but that's a start. The branch seems to work pretty
 well here.

 BTW, it would be nice if I had some more service-side code to review/test
 because just loading HSes does not give me much testing surface. If I had
 some code that also uses the generated HS that would be more useful for
 review/testing. Do you think that's a good time to prepare for me the
 second batch of service-side code for review? Or should I keep reviewing
 this codebase more?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21979#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs