[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25985 [Obfuscation/Snowflake]: Snowflake rendezvous using AMP cache

#25985: Snowflake rendezvous using AMP cache
-----------------------------------+--------------------------------
 Reporter:  twim                   |          Owner:  (none)
     Type:  project                |         Status:  needs_revision
 Priority:  Medium                 |      Milestone:
Component:  Obfuscation/Snowflake  |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:                         |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+--------------------------------

Comment (by dcf):

 Replying to [comment:25 twim]:
 > Replying to [comment:24 dcf]:
 > Thanks to your suggestion I made some constants configurable. One can
 now specify `Client.Scheme` and `Client.CDNDomain`.
 > As you may guess, it was intended to work with the only AMP cache around
 thus the hardcoded values.

 Great. I'm fine with there being defaults, as long as it's possible to
 override them with `-front` and `-url` like the examples in comment:10.

 > >  * The `<style>body {opacity: 0}</style><noscript><style>body
 {opacity: 1}</style></noscript>` doesn't match the documented
 [https://www.ampproject.org/docs/reference/spec/amp-boilerplate.html AMP
 boilerplate code], which is much longer. Is there a reason?
 > This is knowm as "old boilerlate"
 (https://github.com/ampproject/amphtml/commit/0a056ca50ac8cb9ba8e5a6489baeecb5ed958556
 #diff-17672f7dfc8b0583c360b45234dbf59a). The reason is that it's much
 shorter than the new one. I've picked this as a tradeoff to save bandwidth
 as the old boilerplate is still accepted by AMP CDN.
 > Now this is also configurable: set `Server.UseOldAMPBoilterplate` to
 `true` to use shorter boilerplate, or get completely valid 'modern' AMP
 page by default.

 Thanks for the explanation. I didn't know about that. The old boilerplate
 is fine if it's shorter and it works, as long as there's a short comment
 explaining what's going on. I don't think it even needs to be
 configurable, necessarily.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25985#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs