[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18342 [Metrics/Onionoo]: Provide more accurate reverse DNS results
#18342: Provide more accurate reverse DNS results
-----------------------------+--------------------------------
Reporter: cypherpunks | Owner: irl
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: metrics-2018 | Actual Points:
Parent ID: | Points:
Reviewer: karsten | Sponsor:
-----------------------------+--------------------------------
Comment (by irl):
Replying to [comment:32 karsten]:
> Please find
[https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-18342
my task-18342 branch] with three fixup commits.
These all look good.
> There's another issue that I did not fix yet: domain names always end
with a dot, as in `"onionoo.torproject.org."`. Can you find out why this
is the case and fix it?
This is because domain names always end with a dot, to indicate that they
are absolute domain names. I'm sure I tested this and the current
behaviour was to include the dot, but I must have been testing against the
wrong thing as I can see now that we don't currently include the dot. I'll
add a fixup commit to strip them.
> In general, please avoid rebasing branches under review. Just add fixup
or squash commits until we're done, and I'll make sure the end result is
squashed and rebased.
Ok.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18342#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs