[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20700 [Core Tor/Tor]: prop224: Implement standard client authorization

#20700: prop224: Implement standard client authorization
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  haxxpop
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, 035-roadmap-        |  Actual Points:
  master, 035-triaged-in-20180711                |
Parent ID:  #25955                               |         Points:  3
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:33 nickm]:
 > Notes:
 >   * Apparently we have two things called Appendix E in `rend-
 spec-v3.txt` now.  I don't think this is new with this patch, but let's
 fix that.
 >   * When you list "./authorized_clients/alice", etc in appendix F, do
 you intend to specify that this list has to be inside the service
 directory?  I ask because if you're doing this, I don't think it makes
 sense to list them all separately in the torrc, and list the directory
 separately as well.
 >   * Do we want to allow multiple keys per file?
 >   * I'd suggest renaming all the client options so that they don't start
 with "HiddenService": It makes things much easier if only our service-side
 options start with "HiddenService".  How about ClientOnionAuth or
 something?
 >   * We should say what happens if Tor encounters an unrecognized auth-
 type, user name, or onion service name in one of these files.  I say it
 should ignore that key.

 Thanks for the review. Pushed relevant fixes on my github repo, same
 branch name.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20700#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs