[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now
#26398: feature gate testing C code from Rust for now
----------------------------------------------+----------------------------
Reporter: isis | Owner: isis
Type: defect | Status:
| needs_information
Priority: Very High | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.1-alpha
Severity: Normal | Resolution:
Keywords: rust, tor-test, fast-fix, tor-ci | Actual Points:
Parent ID: | Points: 1
Reviewer: nickm | Sponsor:
| Sponsor8-can
----------------------------------------------+----------------------------
Comment (by chelseakomlo):
Replying to [comment:9 nickm]:
> I've merged this to master, and added some previously missing items to
build.rs.
>
> Before we close this, I think we should have a note about how to
actually invoke these tests, if you do want to enable them. I tried
adding --features=test-c-from-rust to test_rust.sh, but it makes most of
our crates' tests fail.
Adding a note that fixing
https://trac.torproject.org/projects/tor/ticket/25386#comment:74 will
allow us to remove this feature gate, and something that we should
prioritize.
In the next couple weeks I will organize a discussion at a patch party and
work with some Rust people to make sure we can resolve this in a way that
allows us to run the full test suite (if someone else wants to take this
on organizing this sooner, please do and I will attend said discussion).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26398#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs