[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes
#3723: Report version of bwscanners in votes
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-bwauth, 035-triaged-in-20180711 | Actual Points:
Parent ID: #25925 | Points:
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by nickm):
Replying to [comment:39 juga]:
> Replying to [comment:38 nickm]:
> > Questions, not necessarily requring changes:
> >
> > * Do we envision ever having a private field in the bwauth file?
>
> AFAIK, we have not talk about it. What do you mean by "private"?, that
would be for?
I mean, would we ever want to have a field that would be part of the
bandwidth file, but _not_ copied into the vote?
> > * And is this "terminator" a change to the existing bandwidth file
format?
>
> No, are you asking that because the name is different?, we changed the
name cause we thought it was less confussing:
https://github.com/torproject/tor/pull/194#discussion_r199334483
Okay, that makes sense.
> > * Does anything use MAX_BW_FILE_HEADERS_LINE_LEN?
>
> It is used in: https://github.com/torproject/tor/pull/241/files#diff-
c93ae3ef7d4ec1024de706403d5ab13eR282
> We thought that we should check not only the length of the headers
smartlist but also the length of the headers string.
> Regarding the name, see discussion in
https://github.com/torproject/tor/pull/194#discussion_r199345734
>
> > Necessary changes:
> >
> > * This branch needs a changes file.
>
> ok, will add it
Thanks! Please make this merge_ready again you do.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3723#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs