[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23846 [Core Tor/Tor]: Use libtool for building shared library

#23846: Use libtool for building shared library
-------------------------------------------------+-------------------------
 Reporter:  hellais                              |          Owner:  sbs
     Type:  enhancement                          |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, s8-api,                  |  Actual Points:
  034-triage-20180328, 034-included-20180402,    |
  034-roadmap-subtask, 035-roadmap-subtask, 035  |
  -triaged-in-20180711                           |
Parent ID:  #25510                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by hellais):

 I started using the branch of nickm called libtool_hack to build a dylib
 on macOS.

 In order to get it to actually build a .dylib on macOS I had to apply this
 patch:
 https://github.com/hellais/tor/commit/163d22294df6674411c3bfe6c46868df995a6bb2.

 I think it would be very useful to have the work in this branch done and
 updated to the latest master so that we can better test `tor_api.h` (it's
 easier to write tests using ffi in python that by writing c code).

 Based on this branch I wrote a simple failing test that makes tor crash
 when the `tor_run_main()` function is called twice. See:
 https://gist.github.com/hellais/b56043d57eb5be885958e80b3665bfe2

 I am not sure if that is due to not all the fixes being part of that
 branch. In the meantime I have started to forward port the changes in this
 branch to the latest master, but there are quite a few conflicts that I am
 not entirely sure what is the best approach to follow to resolve them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23846#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs