[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes
#26939: Privcount blinding and encryption: type fixes
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| assigned
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: privcount, 035-roadmap-master, 035 | Actual Points:
-triaged-in-20180711, rust |
Parent ID: #25669 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by chelseakomlo):
Just to further clarify from the comment on #25669- `usize` is Rust's
equivalent of a `size_t` and therefore iiuc is used to pass around lengths
or offsets of arrays or other collections. I wasn't sure about all of the
uses of `usize` here, so taking another look might be useful. For example,
https://github.com/nmathewson/privcount_shamir/blob/26812d1ab9912a8f36c0e1472b778d61e696c6e9/rust/tests/basic_integration.rs#L27
wasn't clear to me if this represents a length or offset, or the
coordinates for `Params`
https://github.com/nmathewson/privcount_shamir/blob/f679aa90ef3ce0d264c50f7e010b2b8022b96c7c/rust/src/shamir.rs#L15
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26939#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs