[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5262 [Stem]: Implement Safe Cookie in Stem

#5262: Implement Safe Cookie in Stem
----------------------------+-----------------------------------------------
    Reporter:  atagar       |       Owner:  neena 
        Type:  task         |      Status:  closed
    Priority:  normal       |   Milestone:        
   Component:  Stem         |     Version:        
  Resolution:  implemented  |    Keywords:        
      Parent:               |      Points:        
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 Hi Ravi. Merged with some revisions...
 https://gitweb.torproject.org/stem.git/commitdiff/560923cb7b572d02046c6ca2bd5eb4502fa591b3

 This ended up taking me a lot of time to revise, which in retrospect I
 should have expected since it's a big patch. The one main gotcha that I
 think we could have avoided was to make sure your tests passed. I suspect
 that you ran the integ tests, but forgot to run with the 'RUN_ALL' target
 causing your authenticate_safecookie() additions to be partly unexercised.

 That aside, a fantastic addition. Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5262#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs