[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9022 [Pluggable transport]: Create an XMPP pluggable transport



#9022: Create an XMPP pluggable transport
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  feynman 
     Type:  task                 |         Status:  accepted
 Priority:  normal               |      Milestone:          
Component:  Pluggable transport  |        Version:          
 Keywords:                       |         Parent:          
   Points:                       |   Actualpoints:          
---------------------------------+------------------------------------------

Comment(by feynman):

 Replying to [comment:60 asn]:
 > (cont):
 >
 > argparse will make your CLI parsing much simpler and readable. It will
 also give you a usage() function for free. For example, check this
 tutorial: http://pymotw.com/2/argparse/
 >
 > BTW, I like the client_socket and server_socket separation. I also like
 how you splitted your code into more functions. It's easier to understand
 now. Next step would be to split into multiple files. 650 lines of code in
 a single file are a lot for a python project.
 >
 > Cheers.


 I just finished adding argparse, updating the readme file to match the
 modified flags, and split the project into multiple files.

 I also noticed that sleekxmpp uses an RLock for blocking its stream from
 sending data. To make a long story short, that would probably explain why
 a messages seemed to disappear every now and then. Now I have the client
 socket spawn a new thread every time it wants to send data. That should
 fix the problem.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9022#comment:61>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs