[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11216 [BridgeDB]: BridgeDB is parsing PTs from `cached-extrainfo*` files cumulatively

#11216: BridgeDB is parsing PTs from `cached-extrainfo*` files cumulatively
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:  defect   |     Status:  needs_revision
     Priority:           |  Milestone:
  critical               |    Version:
    Component:           |   Keywords:  bridgedb-0.2.x, metrics, bridgedb-
  BridgeDB               |  parsers
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 I reviewed the patch that was emailed to me from the BridgeDB TWN
 advertisement, and it looks really good, and it technically ''does'' fix
 this bug... but it uses the first Pluggable Transport of a given type for
 a given bridge that was found in the `cached-extrainfo` file.

 It should probably check the `published` line from the extrainfo
 descriptor, in order to determine which of the descriptors is newest. This
 would mean that the parser, `bridgedb.Bridges.parseExtraInfoFile()` would
 need to be changed to extract that line. Or, it would need to wait until I
 or someone else finishes #9380 and/or #10725.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11216#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs