[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19021 [Metrics/CollecTor]: improve configuration process
#19021: improve configuration process
-------------------------------+-----------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: merge_ready
Priority: High | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: ctip operation | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+-----------------------------
Comment (by karsten):
Replying to [comment:10 iwakeh]:
> [...] But I'm very reluctant to commit any code that doesn't
> compile or fails tests.
Right, I totally didn't want to suggest that. It's the minor changes like
using `Paths` instead of `File` that could have moved to separate commits.
But it's fine as it is now.
> Regarding the merge:
> We don't have a release yet and the configuration change is not
reflected in the shell scripts,
Right.
> Instead, maybe add this branch to collector.git and once there is a
scheduler patch branch based
> on this branch, both can be merged to the main collector.git master
branch?
> Once the branch is added to the main collector.git this ticket could be
closed as implemented.
There's a small problem with that: Once we push something to
collector.git, it'll stay there forever, or until we ask a Git admin to
remove it. Instead, I'll add a signed note below that I reviewed your
branch so that I can easily merge or cherry-pick it later when we merge
the scheduler patch branch.
{{{
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I reviewed commit 8767c73d0826dfa9aa21e70a2d857c8a2d77e524 of branch
task-19021-improve-conf-process in repository
user/iwakeh/collector.git and suggest merging that to collector.git
master once the scheduling patch branch is ready.
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
iQEcBAEBAgAGBQJXUEV8AAoJEC3ESO/4X7XBSvUIAJZuyJTi/lvcUSwSJXY6QgyV
A8QXGp3CEdROrqbc1fOtvKiOa4FIC5GHOr78BT1FAYuMDgjHrss6po05RwSNaKLX
OeqzGmAF59PFJYmaJ1HidkTlKf1lJneEEveSY9UlVwVWlPlC+W69T8i4WxxbI1Xo
E4oThC47VzyM1Oc+CQ+xAfW/rpH138Z+ntEjIHBtdKoWzS7hBzlNtc9prM8oKIuj
kKKwvZuQQI5SclhEYmJHELBlnlSQ2YTepkMfUCBXlLq3S4WhN/K9tsL5KmlKIW9C
sQv+Qpo4ukaH7rVNCmHZOSov8D3sM+r2bRWW87utCzsKWCjJx5u+SIVPITXzAWg=
=Fhxs
-----END PGP SIGNATURE-----
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19021#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs