[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18291 [Applications/Tor Browser]: Don't use libfaketime anymore for building the Firefox part of Tor Browser
#18291: Don't use libfaketime anymore for building the Firefox part of Tor Browser
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
Type: defect | team
Priority: Medium | Status:
Component: Applications/Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: tbb-gitian, ff45-esr, | Version:
TorBrowserTeam201605, GeorgKoppen201605 | Resolution:
Parent ID: | Actual Points:
Reviewer: | Points:
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):
* status: needs_revision => needs_review
Comment:
The branch bug_18291-v3 has new comments listing which parts are not
reproducible.
https://gitweb.torproject.org/user/boklm/tor-browser-
bundle.git/log/?h=bug_18291-v3
It is adding the following comments:
{{{
diff --git a/gitian/descriptors/linux/gitian-utils.yml
b/gitian/descriptors/linux/gitian-utils.yml
index 723cd1842d6e..0adcf5d43532 100644
--- a/gitian/descriptors/linux/gitian-utils.yml
+++ b/gitian/descriptors/linux/gitian-utils.yml
@@ -125,6 +125,10 @@ script: |
cd ..
# Grabbing the remaining results and making sure timestamps don't spoil
them
+ # Since we stopped using libfaketime, the binutils, gcc, openssl,
+ # libevent archives are no longer reproducible. The main reason
+ # is that they include some .a archives which include timestamps.
+ # Those files are however not part of the files we ship.
cd $INSTDIR
~/build/dzip.sh binutils-$BINUTILS_VER-linux$GBUILD_BITS-utils.zip
binutils
~/build/dzip.sh gcc-$GCC_VER-linux$GBUILD_BITS-utils.zip gcc
diff --git a/gitian/descriptors/mac/gitian-utils.yml
b/gitian/descriptors/mac/gitian-utils.yml
index 63babd7eef5a..33db2e8925a2 100644
--- a/gitian/descriptors/mac/gitian-utils.yml
+++ b/gitian/descriptors/mac/gitian-utils.yml
@@ -54,6 +54,10 @@ script: |
make $MAKEOPTS
make install
cd $INSTDIR
+ # Since we stopped using libfaketime, the clang archive is no longer
+ # reproducible. The reason is that it includes some .a archives and
+ # other files which include timestamps.
+ # Those files are however not part of the files we ship.
~/build/dzip.sh clang-$CLANG_VER-linux64-wheezy-utils.zip clang
cp *utils.zip $OUTDIR/
else
@@ -106,6 +110,10 @@ script: |
cd ..
# Grabbing the results
+ # Since we stopped using libfaketime, the openssl archive is no
+ # longer reproducible. The main reason is that it includes some .a
+ # archives which include timestamps.
+ # Those files are however not part of the files we ship.
cd $INSTDIR
~/build/dzip.sh openssl-$OPENSSL_VER-mac64-utils.zip openssl
~/build/dzip.sh libevent-${LIBEVENT_TAG#release-}-mac64-utils.zip
libevent
diff --git a/gitian/descriptors/windows/gitian-utils.yml
b/gitian/descriptors/windows/gitian-utils.yml
index 8c77c8d62cea..0876bff114b5 100644
--- a/gitian/descriptors/windows/gitian-utils.yml
+++ b/gitian/descriptors/windows/gitian-utils.yml
@@ -180,6 +180,10 @@ script: |
cd ..
# Grabbing the remaining results
+ # Since we stopped using libfaketime, the gcc, gmp, zlib, openssl,
+ # libevent, mingw-w64 archives are no longer reproducible. The main
+ # reason is that they include some .a archives which include
timestamps.
+ # Those files are however not part of the files we ship.
cd $INSTDIR
# We might want to bump binutils independent of bumping mingw-w64.
touch binutils-$BINUTILS_VER-win32-utils.zip
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18291#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs