[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12523 [Applications/Tor Browser]: Backport Firefox patch to mark JIT pages as non-writable
#12523: Backport Firefox patch to mark JIT pages as non-writable
-------------------------------------------------+-------------------------
Reporter: gk | Owner: mcs
Type: enhancement | Status:
Priority: Medium | needs_review
Component: Applications/Tor Browser | Milestone:
Severity: Normal | Version:
Keywords: tbb-security, tbb-firefox-patch, | Resolution:
tbb-hardened, TorBrowserTeam201606R | Actual Points:
Parent ID: #12653 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
Replying to [comment:21 mcs]:
> Replying to [comment:20 arthuredelstein]:
> > I frankly don't understand the JIT code at all, but the backports here
don't have any errors that I can see. If I understand correctly, we need
to add a --non-writable-jitcode flag to our mozconfigs for this to take
effect.
>
> At first I agreed with you, but now I do not think we need to add
anything to our mozconfigs. Because of the following statement inside
js/src/jit/ExecutableAllocator.cpp, this feature is always turned on:
> bool ExecutableAllocator::nonWritableJitCode = true;
> This is the patch that makes that always so:
> https://gitweb.torproject.org/user/brade/tor-
browser.git/commit/?h=bug12523-01&id=da628e779cfcbc70e6dde45b09bdc2495d10570a
>
> Or -- I am misunderstanding something.
No, I think the misunderstanding was mine. After reading further I think
you are correct. Anyhow, these patches looks good as far as I can tell.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12523#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs