[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17868 [Core Tor/Tor]: base64_decode_nopad() destination buffer length problem
#17868: base64_decode_nopad() destination buffer length problem
--------------------------+------------------------------------
Reporter: dgoulet | Owner: nikkolasg
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: 0.1
Reviewer: dgoulet | Sponsor: SponsorR-can
--------------------------+------------------------------------
Comment (by nikkolasg):
Alongside with #14013, I finally found time to finalize it. Thanks for
your comments, they were good !
One line commit message: Decoupled the verification logic from the
decoding logic
=> Moved the decoding logic into its own function (`base64_decode_impl`)
and both `decode64_*` make their own verification logic then call the
decoding logic function.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17868#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs