Re: [tor-bugs] #19253 [Metrics/Onionoo]: replace submodule with released dependency of metrics-lib

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19253: replace submodule with released dependency of metrics-lib
-----------------------------+------------------------------
 Reporter:  iwakeh           |          Owner:
     Type:  task             |         Status:  needs_review
 Priority:  Low              |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Minor            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by iwakeh):

 * status:  merge_ready => needs_review


Comment:

 Good catch! I usually don't download descriptor.jar

 The method for excluding the superfluous files is fine.
 I excluded even the entire contents of META-INF from external jars; mostly
 the pom.xml and pom.properties from apache-commons jars.

 I also restructured the paths a little to have lib names only in one
 place.
 The we named property `lib` actually `libs` in collector; that's why I
 changed it here.
 And, I removed the references to `/usr/share/java`. All third party jars
 should come from the libs-dir.

 hamcrest-core is sufficient for passing the tests.

 I don't have an onionoo data structure at hand, so I only could start the
 war part and look at the static pages; this needs a closer look when
 reviewing.

 I added a small note to INSTALL.

 Patch attached. Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19253#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs