[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19191 [Core Tor/Tor]: {BUG} directory_send_command: Bug: Squid does not like URLs longer than 4095 bytes, and this one is 20515 bytes long
#19191: {BUG} directory_send_command: Bug: Squid does not like URLs longer than
4095 bytes, and this one is 20515 bytes long
------------------------------------------+--------------------------------
Reporter: fk | Owner: nickm
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor:
Component: Core Tor/Tor | 0.2.8.x-final
Severity: Normal | Version: Tor:
Keywords: regression TorCoreTeam201606 | 0.2.8.3-alpha
Parent ID: | Resolution:
Reviewer: | Actual Points: .2
| Points: .2
| Sponsor:
------------------------------------------+--------------------------------
Comment (by nickm):
dgoulet says
>This seems like a logic change though that is quite the difference
between directory_fetches_from_authorities and
directory_must_use_begindir.
>
>However, considering the fact that if we are a relay or dirauth, we don't
tunnel thus setting the limit simply makes sense.
Right, but I think that the new logic is correct. The function asks,
"When is it safe for us to ignore ask for 500 things at a time?" And the
answer is "only when we must tunnel", not "when we don't fetch from
authorities." So I think that the change is right.
fk says:
>so this is probably an unrelated regression.
Yeah, I believe there is no way that the change in
6eeedc02d8aee0bf1eda8e592764ec9c5df4add7 could cause a regression like
that.
So, merging to 0.2.8. Thanks, all!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19191#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs