[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE
#19259: uncaught NFE
-----------------------------+-----------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: needs_information
Priority: High | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Major | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------------
Comment (by karsten):
Fine questions! Let's see:
- The first timestamp should not precede the second, though that might
not be checked in the current code. This is independent of whether
timestamps are on the same day or not, so should contain your lines 1 and
3. I could imagine that these lines don't work well with the
`compressHistory()` method, but I didn't try that out. We could add a
check to make sure these lines are rejected.
- Negative values are fine and simply indicate that a value is missing.
Normally, we'd put in -1.0, but any other negative value should do just
fine. No need to break in such cases.
Note that I took a quick look at the code to answer these questions, but
that doesn't guarantee that I'm right.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19259#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs