[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18933 [Core Tor/Tor]: Several problems with test-network Makefile target
#18933: Several problems with test-network Makefile target
------------------------------------------------+--------------------------
Reporter: isis | Owner:
Type: defect | cypherpunks
Priority: Medium | Status:
Component: Core Tor/Tor | merge_ready
Severity: Normal | Milestone: Tor:
Keywords: 029-nickm-says-yes, review-group-2 | 0.2.9.x-final
Parent ID: | Version: Tor:
Reviewer: nickm | 0.2.8.2-alpha
| Resolution:
| Actual Points:
| Points: 1
| Sponsor: SponsorS
------------------------------------------------+--------------------------
Changes (by nickm):
* status: needs_review => merge_ready
* reviewer: teor => nickm
Comment:
This looks okay to me. I'd like the absolute-path stuff to become a
function someday, but that doesn't seem too urgent.
(Hoping you don't mind me stealing the review from you, teor.)
Calling this merge-ready, but not merging right now, since the patches
don't seem to apply cleanly to master; we'll have to clean it up a little
as we go.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18933#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs