Re: [tor-bugs] #18280 [Core Tor/Tor]: base32 encoding API doesn't work for a source length that is not a multiple of 5 or 8

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18280: base32 encoding API doesn't work for a source length that is not a multiple
of 5 or 8
----------------------------+------------------------------------
 Reporter:  dgoulet         |          Owner:  dgoulet
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-3  |  Actual Points:
Parent ID:  #18278          |         Points:  1
 Reviewer:  nickm           |        Sponsor:  SponsorR-can
----------------------------+------------------------------------

Comment (by nickm):

 NM.1:
   * tor_free, not free().

 NM.2:
   * on the unit tests, how did you generate these values?  I'm a little
 concerned that we're only testing that our implementation matches itself,
 not that it matches the 'correct thing'. Are those hand-generated, or just
 taken from what the code makes today?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18280#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs