[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18875 [Metrics/metrics-lib]: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with getDirectorySignature()

#18875: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with
getDirectorySignature()
---------------------------------+------------------------------
 Reporter:  karsten              |          Owner:  karsten
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:  #19398               |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by iwakeh):

 Seems fine, only I would suggest to make the algorithm types public
 constants.
 Found [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/tree/src/org/torproject/descriptor/impl/RelayNetworkStatusVoteImpl.java?h=task-18875&id=546ba0c16b0ca4e34b09c2cab19dfca38b1a653e#n614
 here] and [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/tree/src/org/torproject/descriptor/impl/DirectorySignatureImpl.java?h=task-18875&id=546ba0c16b0ca4e34b09c2cab19dfca38b1a653e#n89
 here].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18875#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs