[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16998 [Applications/Tor Browser]: Make sure <link rel="preconnect"> adheres to URL bar domain isolation
#16998: Make sure <link rel="preconnect"> adheres to URL bar domain isolation
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
Type: task | arthuredelstein
Priority: High | Status:
Component: Applications/Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: ff45-esr, tbb-linkability, | Version:
tbb-6.0a5, TorBrowserTeam201606R | Resolution:
Parent ID: | Actual Points:
Reviewer: | Points:
| Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
Kathy and I reviewed this and ran the tests (as well as a manual test so
we could look at the domain isolation logging). Everything seems to be
working correctly. Nice work!
It might be helpful to add some comments where you pass an empty string
for the isolation key, e.g., in netwerk/base/Predictor.cpp, inside
IOServiceProxyCallback::OnProxyAvailable(), and in
netwerk/ipc/NeckoParent.cpp. I know Predictor.cpp is OK because that code
is pref'd off. Kathy and I are less confident about NeckoParent.cpp
because we are not as familiar with the IPC code and all the ways it may
be used.
Also, the UUID inside netwerk/base/nsISpeculativeConnect.idl should be
changed. Kathy and I are also worried that changing signatures of existing
IDL'd methods may break add-ons. Should we add new methods instead?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16998#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs