[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17868 [Core Tor/Tor]: base64_decode_nopad() destination buffer length problem

#17868: base64_decode_nopad() destination buffer length problem
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  nikkolasg
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:  dgoulet       |        Sponsor:  SponsorR-can
--------------------------+------------------------------------

Comment (by nikkolasg):

 You're damn right :) After doing your first change, it seemed like we
 could simplify way more ... and we can. I removed the base64_decode_impl()
 because it's in fact useless now. I added another test also to check
 invalid input without padding (srclen % 4 == 1).
 You'll have to double check to make sure it's fine but the *sane
 conditions* seem respected.
 If you want me to work based on your branch, could you give a link to your
 repo ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17868#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs