Re: [tor-bugs] #18280 [Core Tor/Tor]: base32 encoding API doesn't work for a source length that is not a multiple of 5 or 8

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18280: base32 encoding API doesn't work for a source length that is not a multiple
of 5 or 8
----------------------------+------------------------------------
 Reporter:  dgoulet         |          Owner:  dgoulet
     Type:  defect          |         Status:  merge_ready
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-3  |  Actual Points:
Parent ID:  #18278          |         Points:  1
 Reviewer:  nickm           |        Sponsor:  SponsorR-can
----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:14 nickm]:
 > So, if the tests really test correct behavior, then we can make it much
 simpler.  How about `bug18280_029_03_nm` ?  (no guarantees.)

 It does work yes! and much simpler.

 Small detail, replace `buf` by `src` in this comment:

 {{{
  /* set v to the 16-bit value starting at buf[bits/8], 0-padded. */
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18280#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs