Re: [tor-bugs] #19063 [Core Tor/Tor]: The tor_parse_* functions should check and warn on max < min

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19063: The tor_parse_* functions should check and warn on max < min
--------------------------+------------------------------
 Reporter:  teor          |          Owner:  U+039b
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:  small
 Reviewer:                |        Sponsor:
--------------------------+------------------------------

Comment (by U+039b):

 I propose the patch
 [https://trac.torproject.org/projects/tor/attachment/ticket/19063/0001-Fix-19063
 -Add-check-in-utility-macro.patch 0001-Fix-19063-Add-check-in-utility-
 macro.patch].

 (max<min) is considered as an error:

  * add a check in the utility macro CHECK_STRTOX_RESULT.
  * add a test in test/utils.

 No tor_parse_* call violate max>min and tests are ok.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19063#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs