[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19435 [Core Tor/Tor]: Negative number of suppressed messages

#19435: Negative number of suppressed messages
--------------------------+------------------------------------
 Reporter:  twim          |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 NAK on this patch: the point of the rate limiter is to avoid filling the
 log.  If we log up to one message per second, then we will still fill the
 log.

 IMO a  better fix would be to set the rate limiter so that if it is
 INT_MAX, the count does not increment any more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19435#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs