[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19483 [Core Tor/Tor]: Unit test util/time is broken on OpenBSD

#19483: Unit test util/time is broken on OpenBSD
-----------------------------------------------+---------------------------
 Reporter:  teor                               |          Owner:
     Type:  defect                             |         Status:  reopened
 Priority:  Medium                             |      Milestone:  Tor:
Component:  Core Tor/Tor                       |  0.2.9.x-final
 Severity:  Normal                             |        Version:
 Keywords:  integer-safety, TorCoreTeam201607  |     Resolution:
Parent ID:                                     |  Actual Points:  1.0
 Reviewer:                                     |         Points:  0.5
                                               |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by teor):

 gcc on amd64 (and only amd64) is smart enough to elide some of my overflow
 checks:
 {{{
 ../src/common/util.c: In function 'tv_udiff':
 ../src/common/util.c:1454:3: error: logical 'or' of collectively
 exhaustive tests is always true [-Werror=logical-op]
 ../src/common/util.c: In function 'tv_mdiff':
 ../src/common/util.c:1510:3: error: logical 'or' of collectively
 exhaustive tests is always true [-Werror=logical-op]
 cc1: all warnings being treated as errors
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19483#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs