[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3
#21999: The "request English language web pages"-prompt is not working in 7.0a3
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff52-esr, tbb-e10s, tbb-7.0-must, | Actual Points:
TorBrowserTeam201706R, tbb-7.0-issues, tbb- |
regression |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Replying to [comment:10 mcs]:
> Replying to [comment:9 arthuredelstein]:
> > Here's a patch for review:
> > https://github.com/arthuredelstein/torbutton/commit/21999
>
> The code looks okay but Kathy and I have a couple of questions:
> * Why is the delay before showing the prompt only imposed for about:tor?
> * The old code only showed the prompt when the user accessed an HTTP
page. The new code will show it at startup on about:tor, which seems like
a less friendly "first run" experience (mostly because the prompt will
cover up a lot of the about:tor content). Are we okay with this change in
behavior?
No. I think we should try to get it going the way it was implemented in
#18019. Or at least the patch should give a similar experience.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21999#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs