[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7869 [Core Tor/Tor]: ntor-onion-key is padded with an equal sign
#7869: ntor-onion-key is padded with an equal sign
-----------------------------------------------+---------------------------
Reporter: rransom | Owner: Jigsaw52
Type: defect | Status:
| needs_review
Priority: Low | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-relay, intro, review-group-18 | Actual Points:
Parent ID: | Points:
Reviewer: catalyst | Sponsor:
-----------------------------------------------+---------------------------
Comment (by catalyst):
Thanks for the updated patches, and sorry about the delay. I'll comment
on the torspec changes first.
The patch to `dir-spec.txt` looks good. It could possibly be more
specific about referring to the microdescriptors rather than router
descriptors (where I think we should still allow optional padding because
they're self-signed).
There are a few more places that need updated text about `ntor-onion-key`:
* Section 3.3 (Computing microdescriptors) should mention that prior to
consensus method 27, `=` padding is required, and the padding must be
absent in consensus method 27 and later.
* Section 3.8.1 (Forward compatibility) should get an additional line for
"27".
There might be other places I missed; please let me know if you find
others!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7869#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs