[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26196 [Core Tor/Tor]: Abort in test_bridges.c

To: undisclosed-recipients: ;
Subject: Re: [tor-bugs] #26196 [Core Tor/Tor]: Abort in test_bridges.c
From: "Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>
Date: Sun, 03 Jun 2018 12:06:11 -0000
Auto-submitted: auto-generated
Delivered-to: archiver@xxxxxxxx
Delivery-date: Sun, 03 Jun 2018 08:06:21 -0400
In-reply-to: <046.e83adc7a51e94022001c26928de3d0b0@torproject.org>
List-archive: <http://lists.torproject.org/pipermail/tor-bugs/>
List-help: <mailto:tor-bugs-request@lists.torproject.org?subject=help>
List-id: "auto: Tor bug tracker status mails" <tor-bugs.lists.torproject.org>
List-post: <mailto:tor-bugs@lists.torproject.org>
List-subscribe: <https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs>, <mailto:tor-bugs-request@lists.torproject.org?subject=subscribe>
List-unsubscribe: <https://lists.torproject.org/cgi-bin/mailman/options/tor-bugs>, <mailto:tor-bugs-request@lists.torproject.org?subject=unsubscribe>
References: <046.e83adc7a51e94022001c26928de3d0b0@torproject.org>
Reply-to: no-reply@xxxxxxxxxxxxxx, tor-assistants@xxxxxxxxxxxxxx
Sender: "tor-bugs" <tor-bugs-bounces@xxxxxxxxxxxxxxxxxxxx>

#26196: Abort in test_bridges.c
-------------------------------------------------+-------------------------
 Reporter:  gvanem                               |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  crash, tests, 029-backport,          |  Actual Points:
  031-backport 032-backport 033-backport         |
  034-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by rl1987):

 Now that `DEBUG_SMARTLIST` is enabled when fragile hardening is on, there
 are more places in the codebase where we're using smartlist in a way
 that's not exactly right:
 {{{
 dir/v3_networkstatus: [forking] Jun 03 14:45:48.985 [err]
 tor_assertion_failed_: Bug: ./src/common/container.h:70: smartlist_get:
 Assertion sl->num_used > idx failed; aborting. (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.989 [err] Bug: Assertion sl->num_used > idx failed in
 smartlist_get at ./src/common/container.h:70. Stack trace: (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:48.990 [err] Bug:     0   test
 0x000000010d4e3df8 log_backtrace + 72 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.990 [err] Bug:     1   test
 0x000000010d55c461 tor_assertion_failed_ + 385 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.991 [err] Bug:     2   test
 0x000000010d2e276a smartlist_get + 490 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.991 [err] Bug:     3   test
 0x000000010d2e0d03 protover_compute_vote + 3315 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.992 [err] Bug:     4   test
 0x000000010d44a307 networkstatus_compute_consensus + 8823 (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:48.992 [err] Bug:     5   test
 0x000000010cc7664a test_a_networkstatus + 13930 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.992 [err] Bug:     6   test
 0x000000010cf2b5b0 testcase_run_one + 880 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.993 [err] Bug:     7   test
 0x000000010cf2ba5f tinytest_main + 463 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:48.993 [err] Bug:     8   test
 0x000000010cf299ea main + 2218 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 Jun 03 14:45:48.994 [err] Bug:     9   libdyld.dylib
 0x00007fff6619f015 start + 1 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 [Lost connection!]
   [v3_networkstatus FAILED]
 dir/random_weighted: OK
 dir/scale_bw: OK
 dir/clip_unmeasured_bw_kb: [forking] Jun 03 14:45:49.151 [err]
 tor_assertion_failed_: Bug: ./src/common/container.h:70: smartlist_get:
 Assertion sl->num_used > idx failed; aborting. (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.157 [err] Bug: Assertion sl->num_used > idx failed in
 smartlist_get at ./src/common/container.h:70. Stack trace: (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.158 [err] Bug:     0   test
 0x000000010d4e3df8 log_backtrace + 72 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.158 [err] Bug:     1   test
 0x000000010d55c461 tor_assertion_failed_ + 385 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.159 [err] Bug:     2   test
 0x000000010d2e276a smartlist_get + 490 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.159 [err] Bug:     3   test
 0x000000010d2e0d03 protover_compute_vote + 3315 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.160 [err] Bug:     4   test
 0x000000010d44a307 networkstatus_compute_consensus + 8823 (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.160 [err] Bug:     5   test
 0x000000010cc7664a test_a_networkstatus + 13930 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.161 [err] Bug:     6   test
 0x000000010cf2b5b0 testcase_run_one + 880 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.161 [err] Bug:     7   test
 0x000000010cf2ba5f tinytest_main + 463 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.161 [err] Bug:     8   test
 0x000000010cf299ea main + 2218 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.162 [err] Bug:     9   libdyld.dylib
 0x00007fff6619f015 start + 1 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 [Lost connection!]
   [clip_unmeasured_bw_kb FAILED]
 dir/clip_unmeasured_bw_kb_alt: [forking] Jun 03 14:45:49.196 [err]
 tor_assertion_failed_: Bug: ./src/common/container.h:70: smartlist_get:
 Assertion sl->num_used > idx failed; aborting. (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.200 [err] Bug: Assertion sl->num_used > idx failed in
 smartlist_get at ./src/common/container.h:70. Stack trace: (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.200 [err] Bug:     0   test
 0x000000010d4e3df8 log_backtrace + 72 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.200 [err] Bug:     1   test
 0x000000010d55c461 tor_assertion_failed_ + 385 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.201 [err] Bug:     2   test
 0x000000010d2e276a smartlist_get + 490 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.201 [err] Bug:     3   test
 0x000000010d2e0d03 protover_compute_vote + 3315 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.202 [err] Bug:     4   test
 0x000000010d44a307 networkstatus_compute_consensus + 8823 (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.202 [err] Bug:     5   test
 0x000000010cc7664a test_a_networkstatus + 13930 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.202 [err] Bug:     6   test
 0x000000010cf2b5b0 testcase_run_one + 880 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.203 [err] Bug:     7   test
 0x000000010cf2ba5f tinytest_main + 463 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:49.203 [err] Bug:     8   test
 0x000000010cf299ea main + 2218 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 Jun 03 14:45:49.203 [err] Bug:     9   libdyld.dylib
 0x00007fff6619f015 start + 1 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 [Lost connection!]
   [clip_unmeasured_bw_kb_alt FAILED]
 }}}

 {{{
 protover/vote: Jun 03 14:45:59.046 [err] tor_assertion_failed_: Bug:
 ./src/common/container.h:70: smartlist_get: Assertion sl->num_used > idx
 failed; aborting. (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug: Assertion sl->num_used > idx failed in
 smartlist_get at ./src/common/container.h:70. Stack trace: (on Tor 0.3.4.1
 -alpha-dev 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     0   test
 0x000000010d4e3df8 log_backtrace + 72 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     1   test
 0x000000010d55c461 tor_assertion_failed_ + 385 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     2   test
 0x000000010d2e276a smartlist_get + 490 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     3   test
 0x000000010d2e0d03 protover_compute_vote + 3315 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     4   test
 0x000000010ce1cf13 test_protover_vote + 83 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     5   test
 0x000000010cf2b3d9 testcase_run_one + 409 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     6   test
 0x000000010cf2ba5f tinytest_main + 463 (on Tor 0.3.4.1-alpha-dev
 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     7   test
 0x000000010cf299ea main + 2218 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 Jun 03 14:45:59.051 [err] Bug:     8   libdyld.dylib
 0x00007fff6619f015 start + 1 (on Tor 0.3.4.1-alpha-dev 9168cfae11806184)
 make: *** [test] Abort trap: 6
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26196#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Prev by Author: [tor-bugs] #26513 [Applications/Tor Browser]: Read-through NoScript WebExtensions code and check for privacy issues, bugs
Next by Author: Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int
Previous by thread: Re: [tor-bugs] #26196 [Core Tor/Tor]: Abort in test_bridges.c
Next by thread: Re: [tor-bugs] #26196 [Core Tor/Tor]: Abort in test_bridges.c
Index(es):
- Author
- Thread