[tor-bugs] #26336 [Applications/Tor Browser]: Update tor-browser-settings addon for Fennec 61

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26336: Update tor-browser-settings addon for Fennec 61
------------------------------------------+------------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  High                      |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-mobile
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+------------------------
 Installing tor-browser-settings results in:
 {{{
 I/Gecko   (21758): 1528468630190        addons.xpi      WARN    Invalid
 XPI: Error: Install manifest specifies unknown optionsType: 2
 (resource://gre/modules/addons/XPIInstall.jsm:744:13) JS Stack trace:
 loadManifestFromRDF@xxxxxxxxxxxxxx:744:13
 }}}

 Indeed, in install.rdf is:
 {{{
           <em:id>tor-browser-settings@xxxxxxxxxxxxxx</em:id>
           <em:type>2</em:type>
           <em:bootstrap>true</em:bootstrap>
           <em:unpack>false</em:unpack>
           <em:version>1.0.0</em:version>
           <em:name>Tor Browser Settings</em:name>
           <em:description>Customize Orfox-related
 settings.</em:description>
           <em:creator>Thomas Rientjes</em:creator>
 <em:optionsURL>data:text/xml,&lt;placeholder/&gt;</em:optionsURL>
           <em:optionsType>2</em:optionsType>
 }}}

 Only options 3 and 5 are now valid:
 {{{
     if (addon.optionsType &&
         addon.optionsType != AddonManager.OPTIONS_INLINE_BROWSER &&
         addon.optionsType != AddonManager.OPTIONS_TYPE_TAB) {
       throw new Error("Install manifest specifies unknown optionsType: " +
 addon.optionsType);
     }
 }}}

 From 52ESR
 {{{
   // Constants for how Addon options should be shown.
   // Options will be opened in a new window
   OPTIONS_TYPE_DIALOG: 1,
   // Options will be displayed within the AM detail view
   OPTIONS_TYPE_INLINE: 2,
   // Options will be displayed in a new tab, if possible
   OPTIONS_TYPE_TAB: 3,
   // Same as OPTIONS_TYPE_INLINE, but no Preferences button will be shown.
   // Used to indicate that only non-interactive information will be shown.
   OPTIONS_TYPE_INLINE_INFO: 4,
   // Similar to OPTIONS_TYPE_INLINE, but rather than generating inline
   // options from a specially-formatted XUL file, the contents of the
   // file are simply displayed in an inline <browser> element.
   OPTIONS_TYPE_INLINE_BROWSER: 5,
 }}}

 From FF61
 {{{
   // Constants for how Addon options should be shown.
   // Options will be displayed in a new tab, if possible
   OPTIONS_TYPE_TAB: 3,
   // Similar to OPTIONS_TYPE_INLINE, but rather than generating inline
   // options from a specially-formatted XUL file, the contents of the
   // file are simply displayed in an inline <browser> element.
   OPTIONS_TYPE_INLINE_BROWSER: 5,
 }}}

 Maybe we can use `optionType: 5` without too much additional trouble.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26336>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs