[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61
#26233: Rebase Tor Browser patches for FF61
-----------------------------------------------+---------------------------
Reporter: sysrqb | Owner:
| arthuredelstein
Type: enhancement | Status:
| needs_information
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201806R, tbb-mobile | Actual Points:
Parent ID: #25741 | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Changes (by gk):
* status: needs_review => needs_information
Comment:
Replying to [comment:9 arthuredelstein]:
> Replying to [comment:6 gk]:
> > 79289c71dc16e3064e1ceb17fb1900e0d08273d8 -- not okay (4e0aed04f7f7)
> >
> > Where are the changes in nsToolkitProfileService.cpp etc. coming from?
I fail to find them on m-c. It seems to me we don't want to differe more
than needed from Mozilla here.
>
> In our original patch, the `static` keyword has been removed from some
functions in `nsXREDirProvider.h` and so all invocations need to be
modified. Unfortunately some additional invocations appeared in other
files so these need to be modified as well.
I see. What's the reason for doing
{{{
> - rv =
nsXREDirProvider::GetUserAppDataDirectory(getter_AddRefs(file));
> + rv = mDirProvider.GetUserAppDataDirectory(getter_AddRefs(file));
}}}
essentially reverting bug 1443080 and deviating from the fix pattern using
the `GetSingleton()`-approach?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26233#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs