[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21346 [Core Tor/Tor]: Clients with NoIPv4Traffic should only choose IPv6-supporting Exits

#21346: Clients with NoIPv4Traffic should only choose IPv6-supporting Exits
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 031-deferred-20170425,         |  Actual Points:
  032-unreached                                  |
Parent ID:  #21311                               |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 Thank you for the feedback on the PR.

 My question is, should we just give up on this patch? I noticed this code
 in `connection_ap_can_use_exit()` which (like you said and I noticed by
 reading the code) does the same thing my previous patch did:

 {{{
 else if (!conn->entry_cfg.ipv4_traffic && conn->entry_cfg.ipv6_traffic) {
   tor_addr_make_null(&addr, AF_INET6);
   addrp = &addr;
 } else if (conn->entry_cfg.ipv4_traffic && !conn->entry_cfg.ipv6_traffic)
 {
   tor_addr_make_null(&addr, AF_INET);
   addrp = &addr;
 }
 }}}

 If we shouldn't give up, what should I do indead (I can still write a
 patch if we do this route)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21346#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs