[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24977 [Core Tor/Tor]: Non-fatal assertion !(tor_mem_is_zero((const char*)node->hsdir_index->fetch, DIGEST256_LEN))

#24977: Non-fatal assertion !(tor_mem_is_zero((const
char*)node->hsdir_index->fetch, DIGEST256_LEN))
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  asn
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224,                     |  Actual Points:
  034-triage-20180328, 034-removed-20180502      |
Parent ID:                                       |         Points:  1
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 OK people, in branch `bug24977_final` you can see the approach we
 discussed where we use the consensus valid-after to detect outdated state
 and then fix it on-demand:

 https://github.com/torproject/tor/pull/146

 I didn't do the (1) part where we add a timer when we receive a non-live
 consensus that triggers when it becomes live, because I figured out that
 the on-demand approach should cover that too for the HSv3 use case. Let me
 know if you'd like to see that too, in case it helps with the non-HSv3 use
 cases. Perhaps we can have that as a ticket for the future?

 BTW, I choose the nodelist to add the `valid_after` timestamp, since
 that's the data structure that basically carries the HSDir indices. I
 didn't want to add it to each individual `node_t` because that would be a
 bit weird.

 ----

 Please also see commit `2520ee34c` which fixes another client-side case
 which could produce this bug and stack trace. I left more details in the
 commit message.

 Let me know if you have questions or you'd like to see things done
 differently. I think this is still doable for 034.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24977#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs