[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build
#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows
build
--------------------------------------------+------------------------------
Reporter: gk | Owner: tbb-team
Type: task | Status: needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff60-esr, TorBrowserTeam201806 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------------
Changes (by sukhbir):
* status: new => needs_review
Comment:
For review:
https://github.com/azadi/tor-browser-build-1/tree/bug-26203
This should address #26205, #26206, #25837, #26326, #26204.
Some observations:
1. We have a working build of Windows x86_64 with this branch. I verified
it on Windows 10.
2. I think we can do better for #26205 (commit
`93f89a735792e329bd7853bcbd0db056426e32d6`). Please review and suggest.
Also, should this patch go in Firefox (as part of `git_url`) or as
separate patches which we add during the build (current approach)?
3. For `fxc2`, we are pointing to my fork of the project. We will switch
to `mozilla/fxc2` when https://github.com/mozilla/fxc2/pull/1 is merged.
4. For Rust, I made the change below; let me know if we should remove the
guards altogether:
{{{
-[% IF ! c("var/windows") %]
+[% IF ! c("var/windows-i686") %]
}}}
5. For Firefox, I based `gecko-dev/tree/win-ff60` (commit
`be179ca1a0c7812a332b16a4f1b87eb68c629d01`) on `tor-
browser-60.0.1esr-8.0-1` and tjr's patches, including the ones from
https://treeherder.mozilla.org/#/jobs?repo=try&revision=781b545807dfa9d3de23054bf413ec232a9ce1c1
(Sandbox).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26203#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs