[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26269 [Core Tor/Tor]: new compiler warning src/or/router.c:2034:36: warning: potential null pointer dereference
#26269: new compiler warning src/or/router.c:2034:36: warning: potential null
pointer dereference
-------------------------------+------------------------------------
Reporter: toralf | Owner: nickm
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.4.1-alpha
Severity: Normal | Resolution:
Keywords: 034-must fast-fix | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------------
Changes (by nickm):
* status: accepted => needs_review
* keywords: 034-must => 034-must fast-fix
Comment:
I'm fairly sure that there's no underlying bug here, but we should try to
build without warnings in any case.
The router.c code here was introduced in 0.2.8.2-alpha, and the
test_entrynodes.c code in 0.3.0.1-alpha.
So there's need for one fix in 0.2.9: Branch `bug26269_029` with PR at
https://github.com/torproject/tor/pull/147
And for one fix in 0.3.1: Branch `bug26269_031` with PR at
https://github.com/torproject/tor/pull/148
I can't reproduce the compiler errors here, so I'm only _fairly_ sure that
I fixed all the cases. Testing and review would be welcome!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26269#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs