[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25895 [Core Tor/Tor]: Cross-compiling tor rust for Windows is broken

#25895: Cross-compiling tor rust for Windows is broken
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  Hello71
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, 034-proposed, tbb-wants,       |  Actual Points:
  033-backport, 034-roadmap-proposed,  034-must  |
Parent ID:  #25849                               |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 Hello71]:
 > summary (for reviewing): https://cgit.alxu.ca/tor.git/diff/?id=rust-
 cross&id2=fix-rust-tests
 Thanks for the patches! Could you please rebase them on the latest master?
 (without the fix-rust-tests patches?) They don't seem to apply cleanly.
 Also a GitHub pull request would help us to review the changes more
 effectively.

 Please use some other variable like `RUST_TARGET` instead of `TARGET`
 because the variable `target` is set by autoconf someone passes the
 `--target=` option on the `./configure` command line. Or maybe an option
 like `--with-rust-target=` would be better? I'm not sure which would be
 more idiomatic.

 I think `CHOST` and `CBUILD` aren't standard autoconf terminology; what
 system uses those terms? `HOST` and `BUILD` would be better. (These are
 the terms that the help text in `./configure` uses to refer to the
 arguments passed to the `--host=` and `--build=` options.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25895#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs