#26227: Review existing stem.client code
---------------------------+------------------------------
Reporter: dmr | Owner: dmr
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution:
Keywords: client | Actual Points:
Parent ID: | Points:
Reviewer: atagar | Sponsor:
---------------------------+------------------------------
Comment (by atagar):
Thanks Dave. Finally cobbled together some time to begin reviewing this
and looks great! I really love how you broke these up - that's making it
far easier to review.
I've pushed your first five commits with some tweaks, most notably that I
added a LinkProtocol class that centralizes the constants which vary by
version. Mind taking a peek to see what you think?
I've run out of steam for today, and tomorrow I'm hitting the Fremont Fair
with my dad, so I'll continue chewing on these over the course of next
week.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26227#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs