[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23247 [Applications/Tor Browser]: Communicating security expectations for .onion: what to say about different padlock states for .onion services
#23247: Communicating security expectations for .onion: what to say about different
padlock states for .onion services
-------------------------------------------------+-------------------------
Reporter: isabela | Owner:
| pospeselr
Type: project | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, tor-hs, | Actual Points:
TorBrowserTeam201806 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
* keywords: ux-team, tor-hs, TorBrowserTeam201806R => ux-team, tor-hs,
TorBrowserTeam201806
Comment:
Just some nits and then we are ready to ship
s/tor-button's/Torbutton's/
s/implicity/implicitly/
Please no mixed braces usage in
{{{
+ if (!info.isOnion) {
+ hdr = pkiBundle.getString("pageInfo_NoEncryption");
+ if (info.hostName != null)
+ msg1 = pkiBundle.getFormattedString("pageInfo_Privacy_None1",
[info.hostName]);
+ else
+ msg1 = pkiBundle.getString("pageInfo_Privacy_None4");
+ msg2 = pkiBundle.getString("pageInfo_Privacy_None2");
}}}
. Just use braces everywhere in it (even though the Mozilla code itself
violates its guidelines here).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23247#comment:76>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs