Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25787: geoip_load_file() tests don't work on all window build environments
---------------------------------------------+-----------------------------
 Reporter:  nickm                            |          Owner:  nickm
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.4.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 clang (from travis) doesn't seem very happy with the PR :S ... https
 ://travis-ci.org/torproject/tor/jobs/390995401

 {{{
 src/test/test_geoip.c:386:12: error: no previous extern declaration for
       non-static variable 'GEOIP_CONTENT'
       [-Werror,-Wmissing-variable-declarations]
 const char GEOIP_CONTENT[] =
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25787#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs