[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23561 [Applications/Tor Browser]: Fix nsis builds for Windows 64
#23561: Fix nsis builds for Windows 64
-------------------------------------------+------------------------------
Reporter: boklm | Owner: tbb-team
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201806 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------+------------------------------
Changes (by sukhbir):
* status: assigned => needs_review
Comment:
For review:
https://github.com/azadi/tor-browser-build-1/commits/bug-23561
From the commit message:
{{{
Bug 23561: Fix NSIS builds for Windows 64
This commit adds support for building the 64-bit version of NSIS, and
also bumps the verison to 3.03. Doing this enables us to build MAR files
in a 64-bit container for the 64-bit version of Tor Browser; see bug
26363 and bug 24477.
The pe_checksum_fix.py doesn't work in a 64-bit container with the
bundled python-pefile version so we build its latest version to fix this
issue. This change is borrowed from commit bb32ec9 and updates
python-pefile to 2017.11.5.
The Debian package and the patches are no longer required as all changes
were merged upstream in 3.01-1. (See the nsis changelog in Debian.)
}}}
After building Tor Browser nightly 32- and 64-bit, we get the respective
NSIS installers. (Tested on Windows 10.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23561#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs