[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26362 [Applications/Tor Browser]: Use old MAR format when generating the MAR files for the first esr60-based alpha
#26362: Use old MAR format when generating the MAR files for the first esr60-based
alpha
---------------------------------------------+--------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: closed
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: ff60-esr, TorBrowserTeam201806R | Actual Points:
Parent ID: #26050 | Points:
Reviewer: | Sponsor:
---------------------------------------------+--------------------------
Changes (by boklm):
* status: needs_review => closed
* resolution: => fixed
Comment:
Replying to [comment:1 gk]:
> `bug_26362` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_26362&id=befc4910feb0eee2016e10000ed31e3fea7ef6b1)
has a patch for review. I'll file a follow-up ticket keeping track of
removing `MAR_OLD_FORMAT=1` again, later on.
This looks good to me. I pushed it to master as commit
`befc4910feb0eee2016e10000ed31e3fea7ef6b1`.
> boklm: I did not find much about `capture_exec()` but I assumed that the
env vars set are passed along to it. Let me know if thats not the case and
I can try to rip those out of the Makefile rules and put them directly
into the `capture_exec()` calls.
Yes, like normal `exec` the env vars should be passed along.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26362#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs