[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26420 [Core Tor/Stem]: Discuss: Testing - specify literal patterns instead of regex patterns

#26420: Discuss: Testing - specify literal patterns instead of regex patterns
---------------------------+------------------------------
 Reporter:  dmr            |          Owner:  dmr
     Type:  task           |         Status:  needs_review
 Priority:  Very Low       |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  dev testing    |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  atagar         |        Sponsor:
---------------------------+------------------------------
Changes (by dmr):

 * priority:  Medium => Very Low
 * severity:  Normal => Minor


Comment:

 Replying to [comment:2 atagar]:
 > Hi Dave. I hesitate to mention this but option would be to add an
 assertRaisesWith() method. We already wrap unittest's TextTestRunner to
 record test runtimes and add python 2.6 support for a couple methods...
 >
 > https://gitweb.torproject.org/stem.git/tree/stem/util/test_tools.py#n270
 Thanks for the pointer! I was not aware of this wrapping in the code.

 Adding a versioned link here for posterity:
 https://gitweb.torproject.org/stem.git/tree/stem/util/test_tools.py?id=0192b29a4784465e5f69f11ced584a54644e4a90#n270

 > Adding this method would be simple. The only thing that makes me
 hesitate is it's definitely non-standard.
 I agree. The nonstandard aspect was why I was thinking to subclass it.
 That would be at least mildly more obvious.

 > If you'd care to migrate Stem to a simple assertRaisesWith() method then
 feel free. Or not. Happy to go either way. :)
 I think it's not a high priority (changing to `Very Low`), as I think it's
 unlikely that we're getting any false negatives.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26420#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs