Re: [tor-bugs] #25386 [Core Tor/Tor]: Link Rust Tests to C Dependencies in Tor (allow integration testing from Rust to C)

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25386: Link Rust Tests to C Dependencies in Tor (allow integration testing from
Rust to C)
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-test, 033-backport,        |  Actual Points:
  review-group-34, 034-triage-20180328,          |
  034-included-20180401                          |
Parent ID:                                       |         Points:  3
 Reviewer:  isis                                 |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:60 nickm]:
 > https://github.com/torproject/tor/pull/159 is the PR

 Looks good to me, modulo a couple of Hello71's comments about allowing
 spaces in paths. It's still not quite working [https://travis-
 ci.org/torproject/tor/jobs/394177687 on Travis] and it's failing a bit
 differently for me locally, but this does get rid of the linker issues so
 we can probably iterate on this from here on.

 Replying to [comment:62 nickm]:
 >  I've added more to additional_rust_test_fixes to get it "almost"
 working on Travis. More insight may be needed.
 >
 > I've also merged catalyst's "allow_fail_rust" branch to 0.3.4 and 0.3.5
 so that travis won't complain so loudly for now.
 >

 Good call.

 > I'd still like review on additional_rust_test_fixes, with a plan to
 merging it in 0.3.4. I'm also hoping that until we can get the underlying
 linking issues fixes, we can have some rust builders that don't enable
 fragile-hardening, so that we can at least get some visibility into the
 rust tests, and not break them again.

 The additional fixes also look good to me.  I'll mess around this
 afternoon with chasing down some of the remaining errors.

 For the doctests, should we just have a policy of "if you call C and also
 have doctests for your code, then you have to put `ignore` on the doctests
 or otherwise disable them"?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs