[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25386 [Core Tor/Tor]: Link Rust Tests to C Dependencies in Tor (allow integration testing from Rust to C)

#25386: Link Rust Tests to C Dependencies in Tor (allow integration testing from
Rust to C)
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-test, 033-backport,        |  Actual Points:
  review-group-34, 034-triage-20180328,          |
  034-included-20180401                          |
Parent ID:                                       |         Points:  3
 Reviewer:  isis                                 |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:69 nickm]:
 > Replying to [comment:67 Hello71]:
 > > Replying to [comment:64 nickm]:
 > > > Merged "additional_rust_fixes" to 0.3.4 and forward.
 > > >
 > > > > For the doctests, should we just have a policy of "if you call C
 and also have doctests for your code, then you have to put ignore on the
 doctests or otherwise disable them"?
 > > >
 > > > I think that's the best we can do, until rustdoc starts passing the
 right options to rustc.  (Perhaps it is doing so already, and my desktop
 rust is just too old.)
 > >
 > > I guess you missed it on IRC, rustdoc already accepts -C on nightly:
 https://github.com/rust-lang/rust/pull/49956. I assume this will be in
 1.27, to be released today.
 >
 > Okay; we'd have either wait a while to use this, until we can rely on
 folks having this. (Alternatively, we could make it optional.)

 Can we make it optional?

 I wrote extensive rustdoc tests for the PrivCount random double code. I
 was using OSRng as a workaround until #24660, but I'd like to use our
 wrapped Rng instead.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:70>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs