[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26227 [Core Tor/Stem]: Review existing stem.client code
#26227: Review existing stem.client code
---------------------------+------------------------------
Reporter: dmr | Owner: dmr
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution:
Keywords: client | Actual Points:
Parent ID: | Points:
Reviewer: atagar | Sponsor:
---------------------------+------------------------------
Comment (by atagar):
Hi Dave, sorry about the delay! **Finally** done chewing through these and
merged.
Work looks great! Many thanks for the pull request. Opted to pass on three
of the smaller commits...
* **Commit 8353d83 (Remove redundant content-length checks):** Think I'd
prefer to pass on this one. Those conditionals are there so we provide
callers with nicer error messages. True, they might not be necessary but
not spotting a need to drop 'em.
* **Commit 819c1a2 (Refactor fixed_cell_len determination into a
@staticmethod):** No longer necessary due to the LinkProtocol class
addition.
* **Commit 79396f5 (Add TODO notes for Cell types without a unit test
definition):** Eh. Happy to add TODOs but these didn't add much.
Everything else has been merged. Feel free to reopen if there's anything I
missed here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26227#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs