[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15618 [Core Tor/Tor]: Tried to establish rendezvous on non-OR circuit with purpose Acting as rendevous (pending)



#15618: Tried to establish rendezvous on non-OR circuit with purpose Acting as
rendevous (pending)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs needs-insight needs-          |  Actual Points:
  diagnosis                                      |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Dhalgren):

 My thought was the client fix might inhibit the behavior, though of course
 old and hacked clients could still make attempts and trigger the message.

 Anyway the fix is trivial:

 {{{
 --- src/or/rendmid.c.orig
 +++ src/or/rendmid.c
 @@ -227,7 +227,7 @@
             (unsigned)circ->p_circ_id);

    if (circ->base_.purpose != CIRCUIT_PURPOSE_OR) {
 -    log_warn(LD_PROTOCOL,
 +    log_info(LD_PROTOCOL,
               "Tried to establish rendezvous on non-OR circuit with
 purpose %s",
               circuit_purpose_to_string(circ->base_.purpose));
      goto err;
 }}}

 and perfectly safe since the `goto err` means such circuits are discarded.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15618#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs