[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

#21349: Split up very long functions in entrynodes.c
------------------------------------------------+--------------------------
 Reporter:  nickm                               |          Owner:  rl1987
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  unspecified
Component:  Core Tor/Tor                        |        Version:
 Severity:  Minor                               |     Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:  asn                                 |        Sponsor:
------------------------------------------------+--------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Review done in the PR!

 Extremely good work here by rl1987 and really good simplifications all
 around!

 My review comments are mainly code-style and code-improvements, since I
 didn't manage to find a bug. The branch also needs to be rebased to latest
 master, since it doesn't merge cleanly currently because of all the
 various modularization improvements.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21349#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs